Mercurial Mercurial > CrashTest / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix error when a crash is not in a group (invalid crashs mostly)
authorVincent Tondellier <tonton+hg@team1664.org>
Tue, 16 Feb 2016 23:17:21 +0100
changeset 106 97bf7ebb6e44
parent 105 d7258a3a926c
child 107 6f411821b12b
Fix error when a crash is not in a group (invalid crashs mostly)
lib/CrashTest/Controller/CrashReports.pm file | annotate | diff | comparison | revisions
templates/report/crash.html.ep file | annotate | diff | comparison | revisions 
--- a/lib/CrashTest/Controller/CrashReports.pm	Mon Feb 15 00:04:51 2016 +0100
+++ b/lib/CrashTest/Controller/CrashReports.pm	Tue Feb 16 23:17:21 2016 +0100
@@ -62,9 +62,7 @@
     $self->stash(threads => \@threads);
 
     my $group = $self->app->crash_groups->get($uuid);
-    if($group) {
-        $self->stash(crash_group => $group);
-    }
+    $self->stash(crash_group => $group);
     $self->stash(extra_columns => $self->app->config->{WebInterface}->{ExtraColumns}->{Index});
 
     $self->render("report/crash");
--- a/templates/report/crash.html.ep	Mon Feb 15 00:04:51 2016 +0100
+++ b/templates/report/crash.html.ep	Tue Feb 16 23:17:21 2016 +0100
@@ -8,7 +8,9 @@
   %= t div => (class => 'panel-body') => begin
     %= "Crash Time: " . human_date_from_epoch($processed_data->{client_info}->{CrashTime});
     <br/>
-    %= link_to "In crash group \"" . $crash_group->{title} . "\"" => url_for('group', uuid => $crash_group->{uuid})
+    % if(defined($crash_group)) {
+      %= link_to "In crash group \"" . $crash_group->{title} . "\"" => url_for('group', uuid => $crash_group->{uuid})
+    % }
    % end
 % end
CrashTest